Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1903#discussion_r60728363
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/InputFormatVertex.java
---
@@ -64,13 +65,19 @@ public void initializeOnMaster(ClassLoader loader)
throws Exception {
}
// instantiate, if necessary
- InputFormat<?, ?> inputFormat;
+ InputFormat<?, ?> inputFormat = null;
try {
inputFormat =
wrapper.getUserCodeObject(InputFormat.class, loader);
}
catch (Throwable t) {
throw new Exception("Instantiating the InputFormat (" +
formatDescription + ") failed: " + t.getMessage(), t);
}
+ finally{
+ // close the instantiated resources before returning
+ if(inputFormat != null && inputFormat instanceof
RichInputFormat) {
--- End diff --
`inputFormat.configure()` has not been called yet. Why are you closing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
