StephanEwen commented on pull request #15557: URL: https://github.com/apache/flink/pull/15557#issuecomment-819436067
Thanks for the thorough review, @tillrohrmann. I am applying your suggestions now. About the result futures for event sending: Having the `TaskNotRunningException` in the futures doesn't regress here, because that exception was never possible before in how we use the coordinators. A follow-up PR (#15605) ensures the failure cases are taken care of, so these futures are just information for users. We may even change the method to return `void` in the future (no pun intended), I just kept the returned `CompletableFuture` for now because they might come in handy when we want to send events with relaxed guarantees (for events that don't need exactly-ones semantics). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
