alpinegizmo commented on a change in pull request #15610:
URL: https://github.com/apache/flink/pull/15610#discussion_r613176190



##########
File path: docs/content/docs/ops/debugging/flame_graphs.md
##########
@@ -46,6 +46,12 @@ Starting with Flink 1.13, Flame Graphs are natively 
supported in Flink. In order
 Operator's On-CPU Flame Graph
 {{% /center %}}
 
+{{< hint info >}}
+**Warn:** 
+Any measurement process in and of itself inevitably affects the subject of 
measurement (see the [double-split 
experiment](https://en.wikipedia.org/wiki/Double-slit_experiment)). CPU stack 
traces sampling is no exception. In order to prevent the unintended impact of 
such a measurement on a production environment, Flame Graphs are currently 
available as an opt-in feature. To enable it, you'll need to set the 
[`rest.flamegraph.enabled: true`]({{< ref 
"docs/deployment/config">}}#rest-flamegraph-enabled) in `conf/flink-conf.yaml`. 
We recommend enabling it in development and pre-production environments but 
treat it as an experimental feature in the production context.

Review comment:
       ```suggestion
   Any measurement process in and of itself inevitably affects the subject of 
measurement (see the [double-split 
experiment](https://en.wikipedia.org/wiki/Double-slit_experiment)). Sampling 
CPU stack traces is no exception. In order to prevent unintended impacts on 
production environments, Flame Graphs are currently available as an opt-in 
feature. To enable it, you'll need to set [`rest.flamegraph.enabled: true`]({{< 
ref "docs/deployment/config">}}#rest-flamegraph-enabled) in 
`conf/flink-conf.yaml`. We recommend enabling it in development and 
pre-production environments, but you should treat it as an experimental feature 
in production environments.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to