[ 
https://issues.apache.org/jira/browse/FLINK-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251808#comment-15251808
 ] 

ASF GitHub Bot commented on FLINK-3794:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1921#discussion_r60570764
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
 ---
    @@ -280,8 +293,14 @@ class Table(
         * }}}
         */
       def groupBy(fields: String): GroupedTable = {
    -    val fieldsExpr = ExpressionParser.parseExpressionList(fields)
    -    groupBy(fieldsExpr: _*)
    +    // group by on stream tables is currently not supported
    +    tableEnv match {
    --- End diff --
    
    This check can be skip. It will be catched by the other `groupBy`.


> Add checks for unsupported operations in streaming table API
> ------------------------------------------------------------
>
>                 Key: FLINK-3794
>                 URL: https://issues.apache.org/jira/browse/FLINK-3794
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>
> Unsupported operations on streaming tables currently fail during plan 
> translation. It would be nicer to add checks in the Table API methods and 
> fail with an informative message that the operation is not supported. The 
> operations that are not currently supported are:
> - aggregations inside select
> - groupBy
> - distinct
> - join
> We can simply check if the Table's environment is a streaming environment and 
> throw an unsupported operation exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to