[ https://issues.apache.org/jira/browse/FLINK-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251809#comment-15251809 ]
ASF GitHub Bot commented on FLINK-3794: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1921#discussion_r60570939 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/streaming/test/UnsupportedOpsTest.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.scala.table.streaming.test + +import org.apache.flink.api.scala.table._ +import org.apache.flink.api.scala.table.streaming.test.utils.{StreamITCase, StreamTestData} +import org.apache.flink.api.table.{TableException, TableEnvironment} +import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment +import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase +import org.junit.Test + +import scala.collection.mutable + +class UnsupportedOpsTest extends StreamingMultipleProgramsTestBase { + + @Test(expected = classOf[TableException]) + def testSelectWithAggregation(): Unit = { + val env = StreamExecutionEnvironment.getExecutionEnvironment + val tEnv = TableEnvironment.getTableEnvironment(env) + + StreamITCase.testResults = mutable.MutableList() --- End diff -- `testResults` not used. > Add checks for unsupported operations in streaming table API > ------------------------------------------------------------ > > Key: FLINK-3794 > URL: https://issues.apache.org/jira/browse/FLINK-3794 > Project: Flink > Issue Type: Improvement > Components: Table API > Affects Versions: 1.1.0 > Reporter: Vasia Kalavri > Assignee: Vasia Kalavri > > Unsupported operations on streaming tables currently fail during plan > translation. It would be nicer to add checks in the Table API methods and > fail with an informative message that the operation is not supported. The > operations that are not currently supported are: > - aggregations inside select > - groupBy > - distinct > - join > We can simply check if the Table's environment is a streaming environment and > throw an unsupported operation exception. -- This message was sent by Atlassian JIRA (v6.3.4#6332)