KurtYoung commented on a change in pull request #15603:
URL: https://github.com/apache/flink/pull/15603#discussion_r613735406
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
##########
@@ -233,22 +233,7 @@ public void testCancelBatchResult() throws Exception {
furture.get(5, TimeUnit.SECONDS);
Assert.assertEquals(
-
"+---------+-------------+----------------------+--------------------------------+----------------+----------------------------+"
- + System.lineSeparator()
- + "| boolean | int | bigint |
varchar | decimal(10, 5) | timestamp |"
- + System.lineSeparator()
- +
"+---------+-------------+----------------------+--------------------------------+----------------+----------------------------+"
- + System.lineSeparator()
- + "| (NULL) | 1 | 2 |
abc | 1.23 | 2020-03-01 18:39:14.0 |"
- + System.lineSeparator()
- + "| false | (NULL) | 0 |
| 1 | 2020-03-01 18:39:14.1 |"
- + System.lineSeparator()
- + "| true | 2147483647 | (NULL) |
abcdefg | 1234567890 | 2020-03-01 18:39:14.12 |"
- + System.lineSeparator()
- + "| false | -2147483648 | 9223372036854775807 |
(NULL) | 12345.06789 | 2020-03-01 18:39:14.123 |"
- + System.lineSeparator()
- + "Query terminated, received a total of 4 rows"
- + System.lineSeparator(),
+ "Query terminated, received a total of 0 row" +
System.lineSeparator(),
Review comment:
I think this is unexpected. The test is trying to verify that we can
actually receive part of the data until users terminates the batch query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
