StephanEwen commented on a change in pull request #15601:
URL: https://github.com/apache/flink/pull/15601#discussion_r614200957
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorEventValve.java
##########
@@ -92,28 +77,21 @@ public boolean isShut() {
* future.
*
* <p>If the valve is closed this buffers the event and returns an
incomplete future. The future
- * is completed with the original result once the valve is opened. If the
event is never sent
- * (because it gets dropped through a call to {@link #reset()} or {@link
#resetForTask(int)},
- * then the returned future till be completed exceptionally.
+ * is completed with the original result once the valve is opened again.
*
* <p>This method makes no assumptions and gives no guarantees from which
thread the result
* future gets completed.
*/
public void sendEvent(
- SerializedValue<OperatorEvent> event,
- int subtask,
+ Callable<CompletableFuture<Acknowledge>> sendAction,
Review comment:
I don't think immediate failure is necessary. Delayed failure should
fine, it just means we failures are handled later then necessary, and after
steps 3&4 holds back checkpoint for longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
