StephanEwen commented on a change in pull request #15601:
URL: https://github.com/apache/flink/pull/15601#discussion_r614201264
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/RecreateOnResetOperatorCoordinatorTest.java
##########
@@ -32,45 +32,52 @@ Licensed to the Apache Software Foundation (ASF) under one
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
/** Unit tests for {@link RecreateOnResetOperatorCoordinator}. */
public class RecreateOnResetOperatorCoordinatorTest {
+
private static final OperatorID OPERATOR_ID = new OperatorID(1234L, 5678L);
private static final int NUM_SUBTASKS = 1;
@Test
- public void testQuiesceableContextNotQuiesced() throws
TaskNotRunningException {
+ public void testQuiesceableContextForwardsProperties() {
MockOperatorCoordinatorContext context =
new MockOperatorCoordinatorContext(OPERATOR_ID, NUM_SUBTASKS);
RecreateOnResetOperatorCoordinator.QuiesceableContext
quiesceableContext =
new
RecreateOnResetOperatorCoordinator.QuiesceableContext(context);
- TestingEvent event = new TestingEvent();
- quiesceableContext.sendEvent(event, 0);
- quiesceableContext.failJob(new Exception());
-
assertEquals(OPERATOR_ID, quiesceableContext.getOperatorId());
assertEquals(NUM_SUBTASKS, quiesceableContext.currentParallelism());
Review comment:
that's from a different change, I avoid unrelated changes, they confuse
the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
