[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253806#comment-15253806
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user yjshen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1916#discussion_r60728312
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -199,12 +151,12 @@ class Table(
* tab.filter('name === "Fred")
* }}}
*/
- def filter(predicate: Expression): Table = {
-
- relBuilder.push(relNode)
- relBuilder.filter(predicate.toRexNode(relBuilder))
-
- new Table(relBuilder.build(), tableEnv)
+ def filter(predicate: Expression): Table = withPlan {
+// logicalPlan match {
+// case j: Join => j.copy(condition = Some(predicate))
+// case o => Filter(predicate, logicalPlan)
+// }
--- End diff --
Will remove this the next commit.
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
