Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1898#issuecomment-213434810
  
    Thanks for your contribution @rawkintrevo. Good work. I had some minor 
inline comments. I'm mainly concerned about the efficiency of 
`multiRandomSplit` because it can construct some really long pipelines.
    
    I think we should also add online documentation for the `Splitter`. 
Otherwise people will just miss it. You can take a look at `docs/libs/ml/` and 
create a web page for the splitter. We could then create a site with tools from 
where we link to the `Splitter`, for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to