Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60770825
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
---
@@ -0,0 +1,51 @@
+package org.apache.flink.streaming.connectors.kinesis.config;
+
+/**
+ *
+ */
+public class KinesisConfigConstants {
+
+ //
------------------------------------------------------------------------
+ // Configuration Keys
+ //
------------------------------------------------------------------------
+
+ /** The max retries to retrieve metadata from a Kinesis stream using
describeStream API
+ * (Note: describeStream attempts may be temporarily blocked due to AWS
capping 5 attempts per sec) */
+ public static final String CONFIG_STREAM_DESCRIBE_RETRIES =
"flink.stream.describe.retry";
+
+ /** The backoff time between each describeStream attempt */
+ public static final String CONFIG_STREAM_DESCRIBE_BACKOFF =
"flink.stream.describe.backoff";
+
+ /** The initial position to start reading Kinesis streams from (LATEST
is used if not set) */
+ public static final String CONFIG_STREAM_INIT_POSITION_TYPE =
"flink.stream.initpos.type";
+
+ /** The credential provider type to use when AWS credentials are
required (BASIC is used if not set)*/
+ public static final String CONFIG_AWS_CREDENTIALS_PROVIDER_TYPE =
"aws.credentials.provider";
+
+ /** The AWS access key ID to use when setting credentials provider type
to BASIC */
+ public static final String
CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_ACCESSKEYID =
"aws.credentials.provider.basic.accesskeyid";
+
+ /** The AWS secret key to use when setting credentials provider type to
BASIC */
+ public static final String
CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_SECRETKEY =
"aws.credentials.provider.basic.secretkey";
+
+ /** Optional configuration for profile path if credential provider type
is set to be PROFILE */
+ public static final String CONFIG_AWS_CREDENTIALS_PROVIDER_PROFILE_PATH
= "aws.credentials.provider.profile.path";
+
+ /** Optional configuration for profile name if credential provider type
is set to be PROFILE */
+ public static final String CONFIG_AWS_CREDENTIALS_PROVIDER_PROFILE_NAME
= "aws.credentials.provider.profile.name";
+
+ /** The AWS region of the Kinesis streams to be pulled ("us-east-1" is
used if not set) */
+ public static final String CONFIG_AWS_REGION = "aws.region";
+
+
+ //
------------------------------------------------------------------------
+ // Default configuration values
+ //
------------------------------------------------------------------------
+
+ public static final String DEFAULT_AWS_REGION = "us-east-1";
--- End diff --
I think its reasonable to make region a required argument. As a user, more
than once I've found myself mistakened for the AWS SDK not correctly finding
resources, only realizing that it is defaulting to another region unless
specified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
