rkhachatryan commented on a change in pull request #15643:
URL: https://github.com/apache/flink/pull/15643#discussion_r614783703
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -883,8 +883,6 @@ private void onTriggerFailure(@Nullable PendingCheckpoint
checkpoint, Throwable
synchronized (lock) {
abortPendingCheckpoint(checkpoint, cause);
}
- } else {
- LOG.warn("Failed to trigger checkpoint for job {}.)", job,
throwable);
Review comment:
nit: Why can't we just replace `warn` with info and log
`throwable.getMessage()` instead of `throwable`?
So that exception isn't swallowed (in cases other than NOT_ALL_TASK_RUNNING)
and logginng isn't duplicated.
Is it to preserve the current (1.12) behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
