gaoyunhaii commented on a change in pull request #15643:
URL: https://github.com/apache/flink/pull/15643#discussion_r614805524
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -883,8 +883,6 @@ private void onTriggerFailure(@Nullable PendingCheckpoint
checkpoint, Throwable
synchronized (lock) {
abortPendingCheckpoint(checkpoint, cause);
}
- } else {
- LOG.warn("Failed to trigger checkpoint for job {}.)", job,
throwable);
Review comment:
Very thanks for the review! The initial thought is in case in the future
we might throws other exceptions that need to be logged fully, so we may deal
with each exception log separately. But it indeed seems better to not swallow
exceptions, thus I change the PR to be modify the log level directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
