[ 
https://issues.apache.org/jira/browse/FLINK-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325062#comment-17325062
 ] 

Jark Wu commented on FLINK-22179:
---------------------------------

I have tested following items: 

1. Time functions should behaves correctly in both batch and streaming mode, 
and in both tableau and table result mode, and in different time zones. 

{code}
LOCALTIME
LOCALTIMESTAMP
CURRENT_DATE
CURRENT_TIME
CURRENT_TIMESTAMP
NOW()
CURRENT_ROW_TIMESTAMP()
PROCTIME()
{code}

(x) Found issue: [FLINK-22349] LOCALTIMESTAMP doesn't return correct result 
when setting session time zone to 'UTC-10:00'

2. Test ROWTIME attribute that use TIMESTAMP_LTZ, cover `interval join`, 
`temporal join`, `window` scenarios. 

(x) Found issue: [FLINK-22354] Failed to define watermark on computed column of 
CURRENT_TIMESTAMP and LOCALTIMESTAMP

3. Test the `window` result is as expected in DaylightSaving timezone. 

(/) Works correctly.

4. Test ROWTIME attribute + Filesystem partition-time comitter. 
(x) Found issue: [FLINK-22356] Filesystem/Hive partition file is not committed 
when watermark is applied on rowtime of TIMESTAMP_LTZ type





> Manual test time function changes and new time attributes support
> -----------------------------------------------------------------
>
>                 Key: FLINK-22179
>                 URL: https://issues.apache.org/jira/browse/FLINK-22179
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / API
>    Affects Versions: 1.13.0
>            Reporter: Leonard Xu
>            Assignee: Jark Wu
>            Priority: Blocker
>              Labels: release-testing
>             Fix For: 1.13.0
>
>
> * 1. Test time functions return expected value in both batch and streaming 
> mode, we can use Sql-client to test.
> - LOCALTIME
> - LOCALTIMESTAMP
> - CURRENT_DATE
> - CURRENT_TIME
> - CURRENT_TIMESTAMP
> - NOW()
> - PROCTIME()
> * 2. Test PROCTIME attribute works well in different case, eg(`interval 
> join`, `temporal join(lookup)`, `window`), and check 
> sink.partition-commit.trigger  that used proctime is as expected in 
> Hive/FileSystem sink 
> * 3. Test ROWTIME attribute that use TIMESTAMP_LTZ, cover `interval join`, 
> `temporal join`, `window` scenarios
> * 4. Test the `window` result is as expected in  DaylightSaving timezone



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to