XComp commented on a change in pull request #15708:
URL: https://github.com/apache/flink/pull/15708#discussion_r618247208
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherJobTest.java
##########
@@ -59,6 +62,22 @@ public void testStatusWhenInitializing() throws Exception {
assertJobStatus(dispatcherJob, JobStatus.INITIALIZING);
}
+ @Test
+ public void
testArchivedCheckpointingSettingsNotNullWhenInitializingIfCheckpointingIsEnabled()
+ throws Exception {
+ final JobGraph jobGraph = JobGraphTestUtils.singleNoOpJobGraph();
+ jobGraph.setSnapshotSettings(
+ new JobCheckpointingSettings(
+ CheckpointCoordinatorConfiguration.builder().build(),
null));
+
+ TestContext testContext = createTestContext(jobGraph);
+ DispatcherJob dispatcherJob = testContext.getDispatcherJob();
Review comment:
nit: Out of curiosity - did you miss making these `final` or is there
another reason for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
