[
https://issues.apache.org/jira/browse/FLINK-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258032#comment-15258032
]
ASF GitHub Bot commented on FLINK-3771:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1900#issuecomment-214733082
Hi @greghogan,
I looked at the PR in more detail and I have some thoughts.
First, why do we need a `Translate` class and `Translator` interface? Can't
we simply add methods in the `Graph` class that wrap a `MapFunction` or receive
it as an argument like in `mapVertices`?
Second, translating values is already supported by `mapVertices` and
`mapEdges`. Couldn't we simply extend these methods to also support changing
the vertex key types?
Let me know what you think! Thanks.
> Methods for translating Graphs
> ------------------------------
>
> Key: FLINK-3771
> URL: https://issues.apache.org/jira/browse/FLINK-3771
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Fix For: 1.1.0
>
>
> Provide methods for translation of the type or value of graph labels, vertex
> values, and edge values.
> Sample use cases:
> * shifting graph labels in order to union generated graphs or graphs read
> from multiple sources
> * downsizing labels or values since algorithms prefer to generate wide types
> which may be expensive for further computation
> * changing label type for testing or benchmarking alternative code paths
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
