[ 
https://issues.apache.org/jira/browse/FLINK-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258532#comment-15258532
 ] 

ASF GitHub Bot commented on FLINK-3771:
---------------------------------------

Github user greghogan commented on the pull request:

    https://github.com/apache/flink/pull/1900#issuecomment-214825734
  
    By reuse I was referring to needing `MapVertexValueLongToString` and 
`MapEdgeValueLongToString` since the current `Graph` methods operate at the 
level of `Vertex` and `Edge`. And then to translate labels you need 
`MapVertexLabelLongToString` and `MapEdgeLabelLongToString`. In this PR we 
simply have a single `LongToString` which can be used to translate vertex 
labels, edge labels, vertex values, and edge values.
    
    I agree that `Translate` methods taking a `Graph` as input would be better 
as methods on `Graph`.
    
    And if we don't implement as `MapFunction` then we still need `Translate` 
to handle the `TypeInformation`.


> Methods for translating Graphs
> ------------------------------
>
>                 Key: FLINK-3771
>                 URL: https://issues.apache.org/jira/browse/FLINK-3771
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.1.0
>
>
> Provide methods for translation of the type or value of graph labels, vertex 
> values, and edge values.
> Sample use cases:
> * shifting graph labels in order to union generated graphs or graphs read 
> from multiple sources
> * downsizing labels or values since algorithms prefer to generate wide types 
> which may be expensive for further computation
> * changing label type for testing or benchmarking alternative code paths



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to