wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619765557



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c 
%x - %m%n
-END
-}

Review comment:
       First, `setConsoleLogging` is not used in any native K8s related test 
scripts. Second, the native K8s is using `flink-console.properties` from 
release 1.12, which will output logs to console and files simultaneously.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to