wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619764781
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo
"/usr/local/bin/minikube-$MINIKUBE_VERSION")
Review comment:
In linux environment, we are downloading the specific minikube
version(e.g. v1.8.2) and set the correct `MINIKUBE_PATH`. However, on Mac, we
assume that the minikube is pre-installed and we could directly use the
`minikube` command to check status or mounting.
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
stop_kubernetes
}
-function setConsoleLogging {
- cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c
%x - %m%n
-END
-}
Review comment:
First, `setConsoleLogging` is not used in any native K8s related test
scripts. Second, the native K8s is using `flink-console.properties` from
release 1.12, which will output logs to console and files simultaneously.
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo
"/usr/local/bin/minikube-$MINIKUBE_VERSION")
Review comment:
Currently, when running native K8s related test on Mac, we will get
following errors.
```
./test-scripts/common_kubernetes.sh: line 55:
/usr/local/bin/minikube-v1.8.2: No such file or directory
****** Please start/stop minikube manually in non-linux environment. ******
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
