rkhachatryan commented on a change in pull request #15720:
URL: https://github.com/apache/flink/pull/15720#discussion_r620432260
##########
File path: docs/content/docs/connectors/datastream/jdbc.md
##########
@@ -167,15 +177,24 @@ env
ps.setDouble(4, t.price);
ps.setInt(5, t.qty);
},
- JdbcExecutionOptions.builder().build(),
+ JdbcExecutionOptions.builder()
+ .withMaxRetries(0)
+ .build(),
JdbcExactlyOnceOptions.defaults(),
() -> {
// create a driver-specific XA DataSource
+ // The following example is for derby
EmbeddedXADataSource ds = new EmbeddedXADataSource();
ds.setDatabaseName("my_db");
return ds;
});
env.execute();
```
+Postgres XADataSource Example:
+```java
+PGXADataSource pgxaDataSource = new PGXADataSource();
+pgxaDataSource.setUrl(
+"jdbc:postgresql://localhost:5432/postgres");
Review comment:
I think users will likely need this too:
```
xaDataSource.setUser(username);
xaDataSource.setPassword(password);
```
##########
File path: docs/content/docs/connectors/datastream/jdbc.md
##########
@@ -32,8 +32,15 @@ To use it, add the following dependency to your project
(along with your JDBC dr
{{< artifact flink-connector-jdbc withScalaVersion >}}
-Note that the streaming connectors are currently __NOT__ part of the binary
distribution. See how to link with them for cluster execution [here]({{< ref
"docs/dev/datastream/project-configuration" >}}).
+A driver dependency is also required to connect to a specified database. Here
are drivers currently supported:
+
+| Driver | Group Id | Artifact Id | JAR
|
+| :-----------| :------------------| :----------------------|
:----------------|
+| MySQL | `mysql` | `mysql-connector-java` |
[Download](https://repo.maven.apache.org/maven2/mysql/mysql-connector-java/) |
+| PostgreSQL | `org.postgresql` | `postgresql` |
[Download](https://jdbc.postgresql.org/download.html) |
Review comment:
Are you sure we can link to this page? (PostgreSQL has its own license)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
