Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1958#discussion_r62682327
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/logic.scala
 ---
    @@ -21,25 +21,47 @@ import org.apache.calcite.rex.RexNode
     import org.apache.calcite.sql.fun.SqlStdOperatorTable
     import org.apache.calcite.tools.RelBuilder
     
    -abstract class BinaryPredicate extends BinaryExpression { self: Product => 
}
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo
    +import org.apache.flink.api.table.validate.ExprValidationResult
    +
    +abstract class BinaryPredicate extends BinaryExpression {
    +  override def dataType = BasicTypeInfo.BOOLEAN_TYPE_INFO
    +
    +  override def validateInput(): ExprValidationResult = {
    +    if (left.dataType == BasicTypeInfo.BOOLEAN_TYPE_INFO &&
    +        right.dataType == BasicTypeInfo.BOOLEAN_TYPE_INFO) {
    +      ExprValidationResult.ValidationSuccess
    +    } else {
    +      ExprValidationResult.ValidationFailure(s"$this only accept child of 
Boolean Type, " +
    --- End diff --
    
    Please change to `"$this only accepts children of Boolean type"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to