SteNicholas commented on a change in pull request #15812:
URL: https://github.com/apache/flink/pull/15812#discussion_r623531584
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSlotPoolServiceFactory.java
##########
@@ -38,6 +38,7 @@ public DefaultSlotPoolServiceFactory(
@Override
@Nonnull
public SlotPoolService createSlotPoolService(@Nonnull JobID jobId) {
- return new SlotPoolImpl(jobId, clock, rpcTimeout, slotIdleTimeout,
batchSlotTimeout);
+ return new DeclarativeSlotPoolService(
Review comment:
Why not remove `DefaultSlotPoolServiceFactory`? This change make the
`DefaultSlotPoolServiceFactory` same as `DeclarativeSlotPoolServiceFactory`.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolInteractionsTest.java
##########
@@ -18,6 +18,8 @@
package org.apache.flink.runtime.jobmaster.slotpool;
+import com.google.common.collect.Lists;
Review comment:
You should follow the check style and take this import after flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
