[ 
https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279807#comment-15279807
 ] 

ASF GitHub Bot commented on FLINK-1979:
---------------------------------------

Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/656#issuecomment-218399619
  
    Hello @skavulya thank you for your contribution, I'm looking forward to the 
PR!
    
    Re. the regularization penalty, we it changed to make user choice easier, 
e.g. preventing the use of an L1 penalty when L-BFGS is used.
    
    Personally I would prefer to go back to the original design and have it as 
a settable parameter, and apply some sanity checking within the optimizer to 
avoid cases like the one mentioned above.
    
    I would suggest you open the PR and we can discuss it there.


> Implement Loss Functions
> ------------------------
>
>                 Key: FLINK-1979
>                 URL: https://issues.apache.org/jira/browse/FLINK-1979
>             Project: Flink
>          Issue Type: Improvement
>          Components: Machine Learning Library
>            Reporter: Johannes Günther
>            Assignee: Johannes Günther
>            Priority: Minor
>              Labels: ML
>
> For convex optimization problems, optimizer methods like SGD rely on a 
> pluggable implementation of a loss function and its first derivative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to