fsk119 commented on pull request #15558: URL: https://github.com/apache/flink/pull/15558#issuecomment-834225021
Hi, @xiangtao. After quick review, I think it's better to use calcite parser to parse the command. We can throw exception early if users only input `ADD JAR` and users can get more specific error messages. What's more, some other ecosystems that needs `ADD JAR` prefer to use the `CalciteParser` to parse the sqls. It's more friendly for them if we can add these features in the `CalciteParser`. You can refer to #15087 about how to extends the grammer in `CalciteParser`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
