[
https://issues.apache.org/jira/browse/FLINK-22284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343681#comment-17343681
]
Zhilong Hong commented on FLINK-22284:
--------------------------------------
Sorry for the late reply, [~pnowojski]. Recently my outlook mail cannot receive
any mail from JIRA.
I'm not sure what does it refer to for {{request}}. We implemented an idea, and
it works. We can see which remote address the client is trying to request.
{code:java}
if (!future.isSuccess()) {
clientHandler.removeInputChannel(inputChannel);
SocketAddress remoteAddr = future.channel().remoteAddress();
String address =
remoteAddr == null
? String.format(
"%s (#%d)",
connectionId.getAddress(),
connectionId.getConnectionIndex())
: remoteAddr.toString();
inputChannel.onError(
new LocalTransportException(
String.format(
"Sending the partition request to '%s' failed.",
address),
future.channel().localAddress(),
future.cause()));
}
{code}
Do you think it's good to go?
> Null address will be logged when channel is closed in
> NettyPartitionRequestClient
> ---------------------------------------------------------------------------------
>
> Key: FLINK-22284
> URL: https://issues.apache.org/jira/browse/FLINK-22284
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Network
> Affects Versions: 1.13.0
> Reporter: Zhilong Hong
> Priority: Minor
> Fix For: 1.14.0
>
> Attachments: exception.png
>
>
> In NettyPartitionRequestClient#requestSubpartition, when a channel is closed,
> the channel will throw a LocalTransportException with the error message
> "Sending the partition request to 'null' failed.". The message is confusing
> since we wouldn't know where the remote client connected to this channel
> locates, and we couldn't track down to that TaskExecutor and find out what
> happened.
>
> Also I'm wondering that should we use TransportException instead of
> LocalTransportException here, because it's a little confusing to see a
> LocalTransportException is thrown out when a remote channel is closed.
>
> !exception.png!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
