beyond1920 commented on a change in pull request #14830:
URL: https://github.com/apache/flink/pull/14830#discussion_r634001661
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala
##########
@@ -470,20 +470,21 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
case _: StreamPhysicalGroupAggregate | _:
StreamPhysicalGroupTableAggregate |
_: StreamPhysicalLimit | _: StreamPhysicalPythonGroupAggregate |
- _: StreamPhysicalPythonGroupTableAggregate =>
- // Aggregate, TableAggregate and Limit requires update_before if there
are updates
+ _: StreamPhysicalPythonGroupTableAggregate |
Review comment:
I use three sub-classes as previous version. I thought author maybe have
reason to use three sub-classes instead of
`StreamPhysicalGroupWindowAggregateBase `, for example, prevent the misuse of
the parent class when adding a new child class in the future ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
