Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1984#issuecomment-219673873
Overall, the code looks very good! I had some inline comments about
Javadoc/comments.
One thing that might be wrong, though is the interplay between
`CheckpointableInputFormat.getCurrentChannelState()` and
`SplitReader.getReaderState()`. In the latter to check whether the result of
the former is null, and then do something based on this. The former, however
will never return `null` but instead always returns a `Tuple2` that can have
fields set to `null`. This might be an artifact form an earlier mode of
implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
