echauchot commented on a change in pull request #15156:
URL: https://github.com/apache/flink/pull/15156#discussion_r639604859
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowSerializationSchema.java
##########
@@ -157,7 +157,7 @@ public int hashCode() {
//
--------------------------------------------------------------------------------------------
- private GenericRecord convertRowToAvroRecord(Schema schema, Row row) {
+ public GenericRecord convertRowToAvroRecord(Schema schema, Row row) {
Review comment:
great suggestion, I was a bit too quick with the instance ! Thanks !
Refactoring to static bunch of methods (basically convert* methods) works so no
state needed. I'll extract them to a util class in flink-avro package (as these
methods depend on avro) and refer it in flink-avro/AvroRowSerializationSchema
and flink-parquet/ParquetAvroInputFormat. But the module dep will remain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
