echauchot commented on a change in pull request #15156:
URL: https://github.com/apache/flink/pull/15156#discussion_r642543053
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowSerializationSchema.java
##########
@@ -157,7 +157,7 @@ public int hashCode() {
//
--------------------------------------------------------------------------------------------
- private GenericRecord convertRowToAvroRecord(Schema schema, Row row) {
+ public GenericRecord convertRowToAvroRecord(Schema schema, Row row) {
Review comment:
I extracted conversion methods to a new util called _AvroConversions_ in
flink-avro module
I isolated this change into a different commit. Indeed, IMHO we should keep
this commit separated for isolation/revert purposes as it concerns a different
module (flink-avro). I found that it was not necessary to open a different
ticket just for a refactoring such as this. A separate commit seems enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
