qingdao81 commented on pull request #15808:
URL: https://github.com/apache/flink/pull/15808#issuecomment-849420502


   I added another commit which forwards the `registryConfig` to the 
`RestService`:
   
https://github.com/apache/flink/pull/15808/commits/070930ab00fecf6d07c01f3d02f4894dd8625a3a#diff-5f30e0f1719a976a878d0d07e9e9d47fac7f3a5d6daa7631349439c23f5320ffR72
   
   The `RestService` uses a `BasicAuthCredentialProvider`:
   
   ```
   public void configure(Map<String, ?> configs) {
           String basicCredentialsSource = 
(String)configs.get("basic.auth.credentials.source");
           String bearerCredentialsSource = 
(String)configs.get("bearer.auth.credentials.source");
           if (isNonEmpty(basicCredentialsSource) && 
isNonEmpty(bearerCredentialsSource)) {
               throw new ConfigException(String.format("Only one of '%s' and 
'%s' may be specified", "basic.auth.credentials.source", 
"bearer.auth.credentials.source"));
           } else {
               if (isNonEmpty(basicCredentialsSource)) {
                   BasicAuthCredentialProvider basicAuthCredentialProvider = 
BasicAuthCredentialProviderFactory.getBasicAuthCredentialProvider(basicCredentialsSource,
 configs);
                   
this.setBasicAuthCredentialProvider(basicAuthCredentialProvider);
               } else if (isNonEmpty(bearerCredentialsSource)) {
                   BearerAuthCredentialProvider bearerAuthCredentialProvider = 
BearerAuthCredentialProviderFactory.getBearerAuthCredentialProvider(bearerCredentialsSource,
 configs);
                   
this.setBearerAuthCredentialProvider(bearerAuthCredentialProvider);
               }
   
               String proxyHost = (String)configs.get("proxy.host");
               Object proxyPortVal = configs.get("proxy.port");
               Integer proxyPort = proxyPortVal instanceof String ? 
Integer.valueOf((String)proxyPortVal) : (Integer)proxyPortVal;
               if (isValidProxyConfig(proxyHost, proxyPort)) {
                   this.setProxy(proxyHost, proxyPort);
               }
   
           }
       }
   ```
   
   That should hopefully do the same as your change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to