wuchong commented on a change in pull request #16010:
URL: https://github.com/apache/flink/pull/16010#discussion_r642438114
##########
File path: flink-table/flink-sql-client/src/test/resources/sql/set.q
##########
@@ -176,6 +176,10 @@ ADD JAR '$VAR_UDF_JAR_PATH';
[INFO] The specified jar is added into session classloader.
!info
+SHOW JARS;
Review comment:
Please also add the command after `reset`.
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java
##########
@@ -261,6 +261,7 @@ private Configuration getConfiguration() {
private void validateAddJar(String jarPath) throws IOException {
sessionContext.addJar(jarPath);
+ assertEquals(Collections.singletonList(udfJar.getPath()),
sessionContext.listJars());
Review comment:
Please also add the assert after `sessionContext.reset()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
