echauchot commented on a change in pull request #15156:
URL: https://github.com/apache/flink/pull/15156#discussion_r642958857
##########
File path: flink-formats/flink-parquet/pom.xml
##########
@@ -51,10 +51,24 @@ under the License.
<scope>provided</scope>
</dependency>
+<!-- jackson-databind is big and in a compile transitive dep of
flink-avro, exclude it and import it in runtime classpath-->
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-avro</artifactId>
<version>${project.version}</version>
+ <optional>true</optional>
+ <exclusions>
+ <exclusion>
+
<groupId>com.fasterxml.jackson.core</groupId>
+
<artifactId>jackson-databind</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
+ <scope>runtime</scope>
Review comment:
ah, yes, right, I forgot this dep was shaded. Thanks for pointing out !
Cleaning and leaving only the optional dep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
