dawidwys commented on a change in pull request #16055:
URL: https://github.com/apache/flink/pull/16055#discussion_r644685897
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTaskTest.java
##########
@@ -86,21 +90,30 @@
@Test
public void testMetrics() throws Exception {
+ testMetrics(
+ SourceOperatorStreamTask::new,
+ new SourceOperatorFactory<>(
+ new MockSource(Boundedness.BOUNDED, 1),
WatermarkStrategy.noWatermarks()),
+ lessThanOrEqualTo(1_000_000d));
+ }
+
+ public static void testMetrics(
Review comment:
nit: Could we move it to a separate class (either a common base class or
e.g. `SourceTaskTestSet`)? It looks a bit fishy to call a static method from a
different test class.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -72,28 +72,6 @@
private final ChannelStatePersister channelStatePersister;
- public LocalInputChannel(
Review comment:
Thanks for taking care of the quality of our code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
