AHeise commented on a change in pull request #16066:
URL: https://github.com/apache/flink/pull/16066#discussion_r644609088



##########
File path: 
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/SnapshotUtils.java
##########
@@ -48,7 +48,7 @@ private SnapshotUtils() {}
             throws Exception {
 
         CheckpointOptions options =
-                new CheckpointOptions(
+                CheckpointOptions.forConfig(

Review comment:
       Adjust commit message.

##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -384,31 +384,25 @@ public TaskAcknowledgeResult acknowledgeTask(
             long ackTimestamp = System.currentTimeMillis();
 
             long stateSize = 0L;
+            for (OperatorIDPair operatorID : operatorIDs) {

Review comment:
       Is this commit really needed? Conceptually it should only apply to 
rescaling.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to