zentol commented on a change in pull request #16132:
URL: https://github.com/apache/flink/pull/16132#discussion_r649114040
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileExecutionGraphInfoStoreTest.java
##########
@@ -341,9 +344,11 @@ public void testMaximumCapacity() throws IOException {
/** Tests that a session cluster can terminate gracefully when jobs are
still running. */
@Test
public void testPutSuspendedJobOnClusterShutdown() throws Exception {
+ final Duration timeout = Duration.ofSeconds(5);
try (final MiniCluster miniCluster =
new PersistingMiniCluster(new
MiniClusterConfiguration.Builder().build())) {
miniCluster.start();
+ CommonTestUtils.waitUntilCondition(miniCluster::isRunning,
Deadline.fromNow(timeout));
Review comment:
~~Have you considered the possibility that miniCluster.start() maybe
throws an exception (== cluster never starting properly), but this exception
being masked by the issue during the shutdown?~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
