fapaul commented on a change in pull request #16132:
URL: https://github.com/apache/flink/pull/16132#discussion_r649207857
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileExecutionGraphInfoStoreTest.java
##########
@@ -341,11 +346,29 @@ public void testMaximumCapacity() throws IOException {
/** Tests that a session cluster can terminate gracefully when jobs are
still running. */
@Test
public void testPutSuspendedJobOnClusterShutdown() throws Exception {
+ final Duration timeout = Duration.ofSeconds(5);
try (final MiniCluster miniCluster =
new PersistingMiniCluster(new
MiniClusterConfiguration.Builder().build())) {
miniCluster.start();
final JobGraph jobGraph = JobGraphTestUtils.singleNoOpJobGraph();
+ final JobID jobId = jobGraph.getJobID();
miniCluster.submitJob(jobGraph);
+ CommonTestUtils.waitUntilCondition(
+ () -> {
+ // Wait until job is FINISHED which indicates that the
resource manager was
+ // reachable
+ try {
+ return miniCluster.getJobStatus(jobId).get() ==
JobStatus.FINISHED;
Review comment:
You are completely right even the first version was not 100% ensuring
the behavior. I changed the test setup to use blocking job vertex and wait
until it is running before doing the shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
