JingsongLi commented on a change in pull request #16096:
URL: https://github.com/apache/flink/pull/16096#discussion_r651808254



##########
File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/metadata/FlinkMetadata.java
##########
@@ -238,4 +239,20 @@ ImmutableBitSet getUniqueGroups(
             RelWindowProperties getWindowProperties(RelNode r, 
RelMetadataQuery mq);
         }
     }
+
+    /** Metadata about which combinations of columns are change log upsert 
identifiers. */
+    public interface ChangeLogUpsertKeys extends Metadata {
+        Method METHOD = Types.lookupMethod(ChangeLogUpsertKeys.class, 
"getChangeLogUpsertKeys");
+
+        MetadataDef<ChangeLogUpsertKeys> DEF =
+                MetadataDef.of(
+                        ChangeLogUpsertKeys.class, 
ChangeLogUpsertKeys.Handler.class, METHOD);
+
+        Set<ImmutableBitSet> getChangeLogUpsertKeys();

Review comment:
       I understand that your requirement is to ensure the order when it is not 
forward, but the problem here is different.
   
   Even if we know the distribution keys, the operator in the middle may also 
lead to the disorder of upsert keys, which we also need to identify.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to