[
https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297818#comment-15297818
]
ASF GitHub Bot commented on FLINK-3941:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2025#discussion_r64339091
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/UnionITCase.scala
---
@@ -54,7 +54,22 @@ class UnionITCase(
}
@Test
- def testTernaryUnion(): Unit = {
+ def testUnion(): Unit = {
--- End diff --
There were some concerns about the build time of the `flink-table` module
lately. In the past, we added quite a few integration tests without thinking
about the added coverage vs. build time trade-off.
I would propose to replace the `testUnionWithFilter()` and
`testUnionWithJoin()` tests with your new methods because these methods do not
add to test coverage, IMO.
> Add support for UNION (with duplicate elimination)
> --------------------------------------------------
>
> Key: FLINK-3941
> URL: https://issues.apache.org/jira/browse/FLINK-3941
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Fabian Hueske
> Assignee: Yijie Shen
> Priority: Minor
>
> Currently, only UNION ALL is supported by Table API and SQL.
> UNION (with duplicate elimination) can be supported by applying a
> {{DataSet.distinct()}} after the union on all fields. This issue includes:
> - Extending {{DataSetUnion}}
> - Relaxing {{DataSetUnionRule}} to translated non-all unions.
> - Extend the Table API with union() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
