[ 
https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297823#comment-15297823
 ] 

ASF GitHub Bot commented on FLINK-3941:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/2025#issuecomment-221186678
  
    Thanks for the PR, @yjshen. Looks good except for a few minor comments.
    Can you also add one test method to the Scala SQL UnionITCase, such that 
the SQL side is also covered?
    
    Union on streams cannot be supported right now. It would need a lot of the 
windowing logic to deduplicate rows.
    
    Thanks, Fabian


> Add support for UNION (with duplicate elimination)
> --------------------------------------------------
>
>                 Key: FLINK-3941
>                 URL: https://issues.apache.org/jira/browse/FLINK-3941
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Yijie Shen
>            Priority: Minor
>
> Currently, only UNION ALL is supported by Table API and SQL.
> UNION (with duplicate elimination) can be supported by applying a 
> {{DataSet.distinct()}} after the union on all fields. This issue includes:
> - Extending {{DataSetUnion}}
> - Relaxing {{DataSetUnionRule}} to translated non-all unions.
> - Extend the Table API with union() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to