Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655118982
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box
usage. However, the value of `-1` is illegal and what I thought is like
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box
usage. However, the value of `-1` is illegal and what I thought is like:
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
What do you think of this?
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Actually, the default value of `500ms` you said really confused me, this
option is a user-control value and have no default value. Where did you find
the `500ms` configuration?
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
This method is already deprecated, and `500ms` is really too quick for
production users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
