tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655171989
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 180s？In order to be consistent with the code, is it more
appropriate to use 500ms？
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 3min？In order to be consistent with the code, is it more
appropriate to use 500ms？
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
You can see it here
[StreamExecutionEnvironment#enableCheckpointing](https://github.com/apache/flink/blob/60c7d9e77a6e9d82e0feb33f0d8bc263dddf2fd9/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java/#L518)
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Yes, I also think it's too quick. I will change it to 3min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
