gaoyunhaii commented on a change in pull request #15055:
URL: https://github.com/apache/flink/pull/15055#discussion_r657832236
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/TestInputChannel.java
##########
@@ -190,6 +190,9 @@ public void resumeConsumption() {
isBlocked = false;
}
+ @Override
+ public void acknowledgeAllRecordsProcessed() throws IOException {}
Review comment:
It seems we could not call
`inputGate.acknowledgeAllRecordsProcessed(this);` here since the call is from
`SingleInputGate` to `InputChannel`, thus we could not call the method in
`InputGate` again.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/TestInputChannel.java
##########
@@ -190,6 +190,9 @@ public void resumeConsumption() {
isBlocked = false;
}
+ @Override
+ public void acknowledgeAllRecordsProcessed() throws IOException {}
Review comment:
It seems we could not call
`inputGate.acknowledgeAllRecordsProcessed(this);` here since the call is from
`SingleInputGate` to `InputChannel`, thus we could not call the method in
`InputGate` again~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
