dawidwys commented on a change in pull request #15055:
URL: https://github.com/apache/flink/pull/15055#discussion_r657836505



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/TestInputChannel.java
##########
@@ -190,6 +190,9 @@ public void resumeConsumption() {
         isBlocked = false;
     }
 
+    @Override
+    public void acknowledgeAllRecordsProcessed() throws IOException {}

Review comment:
       You're right? Would it work with an `UnsupportedOperationException`? If 
not then let's leave it empty.

##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/TestInputChannel.java
##########
@@ -190,6 +190,9 @@ public void resumeConsumption() {
         isBlocked = false;
     }
 
+    @Override
+    public void acknowledgeAllRecordsProcessed() throws IOException {}

Review comment:
       You're right! Would it work with an `UnsupportedOperationException`? If 
not then let's leave it empty.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to