rkhachatryan commented on pull request #15420:
URL: https://github.com/apache/flink/pull/15420#issuecomment-867678787


   I've updated the PR, PTAL @Myasuka and @curcur (@Zakelly do you have any 
other concerns?)
   
   @curcur 
   Regarding `completeRestore()`,
   I'm not sure I fully understand your point. Is it about calling  before 
completing recovery of the underlying backend?
   But `ChangelogKeyedStateBackend.completeRestore()` is called from 
`ChangelogBackendRestoreOperation.restore()` - after creating the underlying 
state backend (in fact, it is a constructor argument).
   
   Regarding `InMemoryChangelogStateHandle.getKeyGroupRange()` - I've added an 
implementation, thanks for pointing out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to