[
https://issues.apache.org/jira/browse/FLINK-23154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369299#comment-17369299
]
Dian Fu edited comment on FLINK-23154 at 6/25/21, 7:23 AM:
-----------------------------------------------------------
Adding tests for cases where Python VM is needed inside flink-python module is
a good idea. PythonFunctionFactoryTest is such an example:
- It's triggered in a Python test case (test_sql.py) which runs in a Python VM
- During running, it will executes the Java test case
PythonFunctionFactoryTest via Py4J and PythonFunctionFactoryTest is the real
test we want to test
- When PythonFunctionFactoryTest needs to parse Python UDFs, it could reuse
the Python VM launched at step 1
was (Author: dian.fu):
Adding tests for cases where Python VM is needed inside flink-python module is
a good idea. PythonFunctionFactoryTest is such an example:
- It's triggered in a Python test case which runs in a Python VM
- During running, it will executes the Java test case PythonFunctionFactoryTest
via Py4J and PythonFunctionFactoryTest is the real test we want to test
- When PythonFunctionFactoryTest needs to parse Python UDFs, it could reuse the
Python VM launched at step 1
> Fix Python PackagedProgramRetrieverImplTest implementations
> -----------------------------------------------------------
>
> Key: FLINK-23154
> URL: https://issues.apache.org/jira/browse/FLINK-23154
> Project: Flink
> Issue Type: Bug
> Components: API / Python
> Reporter: Matthias
> Priority: Major
>
> We refactored the {{PackagedProgramRetriever}} class hierarchy as part of
> FLINK-21445. As part of this, I added some tests for the Python path but
> didn't look to deep into how to set up the flink python opt folder within the
> test infrastructure. Instead, I added {{Assume}} calls.
> This ticket is about removing these {{Assume}} calls and implementing the
> tests properly.
> It affects testss in {{FromJarEntryClassInformationProviderTest}} and
> {{PackagedProgramRetrieverImplTest}}.
> --
> The corresponding code changes are still subject to change and are currently
> under review in a [draft PR for
> FLINK-21445|https://github.com/apache/flink/pull/16286].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
