[ 
https://issues.apache.org/jira/browse/FLINK-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370393#comment-17370393
 ] 

Jingsong Lee commented on FLINK-22781:
--------------------------------------

Hi Jing, Thanks for the summarization.

First of all, I don't recommend the user to configure 
{{table.exec.emit.allow-latenss}}. TTL should be configured for normal 
operations. (I believe TTL may even have a default value on every platform.)

Why needs to configure {{table.exec.emit.late-fire.delay}} ? I think firing on 
every element is a good start. So can we just set the default value to zero?

So, actually, users just need to configure late-fire.

Another choice is your recommend, just configure allow-lateness.

I think we should make a decision for long-term development. Always take one 
out. (Deprecated one and remove it after next few release)

> Incorrect result for group window aggregate when mini-batch is enabled
> ----------------------------------------------------------------------
>
>                 Key: FLINK-22781
>                 URL: https://issues.apache.org/jira/browse/FLINK-22781
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.14.0
>            Reporter: godfrey he
>            Assignee: JING ZHANG
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> We can reproduce this issue through adding the following code to 
> {{GroupWindowITCase#testWindowAggregateOnUpsertSource}} method:
> {code:java}
>     tEnv.getConfig.getConfiguration.setBoolean(
>       ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED, true)
>     tEnv.getConfig.getConfiguration.set(
>       ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY, 
> Duration.ofSeconds(1))
>     tEnv.getConfig.getConfiguration.setLong(
>       ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 10L)
> {code}
> The reason is the group window without any data (the data may be retracted) 
> should not send any record.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to