[
https://issues.apache.org/jira/browse/FLINK-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370397#comment-17370397
]
Jark Wu commented on FLINK-22781:
---------------------------------
If we don't consider backward-compatibility, I think using just
{{table.exec.emit.allow-lateness}} to enable late firing is a good idea.
{{table.exec.emit.late-fire.delay}} can be zero to fire on every late elements,
{{table.exec.emit.late-fire.delay}} can be removed because it has been
substituted by allow-lateness.
Actually they are still Experimental APIs and never public on docs.
For the temporary solution, I think we can go with [~lzljs3620320]'s proposal
and deprecate {{table.exec.emit.late-fire.delay}}, but keep
backward-compatibility.
For the long term, I think we should provide EMIT sytanx to make the behavior
more explicitly and can have more fine-grained emit strategies. With the EMIT
syntax, users should be able to declare {{ALLOW LATENESS}} clause. For example:
{code}
EMIT
DELAY '1' MINUTE BEFORE WATERMARK,
NO DELAY AFTER WATERMARK WITH ALLOW LATENESS '1' HOUR
{code}
> Incorrect result for group window aggregate when mini-batch is enabled
> ----------------------------------------------------------------------
>
> Key: FLINK-22781
> URL: https://issues.apache.org/jira/browse/FLINK-22781
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.14.0
> Reporter: godfrey he
> Assignee: JING ZHANG
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> We can reproduce this issue through adding the following code to
> {{GroupWindowITCase#testWindowAggregateOnUpsertSource}} method:
> {code:java}
> tEnv.getConfig.getConfiguration.setBoolean(
> ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED, true)
> tEnv.getConfig.getConfiguration.set(
> ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ALLOW_LATENCY,
> Duration.ofSeconds(1))
> tEnv.getConfig.getConfiguration.setLong(
> ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_SIZE, 10L)
> {code}
> The reason is the group window without any data (the data may be retracted)
> should not send any record.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
