zentol commented on a change in pull request #16265: URL: https://github.com/apache/flink/pull/16265#discussion_r660560618
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSystem.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.akka.AkkaUtils; +import org.apache.flink.runtime.rpc.AddressResolution; +import org.apache.flink.runtime.rpc.RpcSystem; + +import javax.annotation.Nullable; + +import java.net.InetSocketAddress; +import java.net.UnknownHostException; + +/** {@link RpcSystem} implementation based on Akka. */ +public class AkkaRpcSystem implements RpcSystem { + + @Override + public RpcServiceBuilder localServiceBuilder(Configuration configuration) { + return AkkaRpcServiceUtils.localServiceBuilder(configuration); + } + + @Override + public RpcServiceBuilder remoteServiceBuilder( + Configuration configuration, + @Nullable String externalAddress, + String externalPortRange) { + return AkkaRpcServiceUtils.remoteServiceBuilder( + configuration, externalAddress, externalPortRange); + } + + @Override + public InetSocketAddress getInetSocketAddressFromRpcUrl(String url) throws Exception { + return AkkaUtils.getInetSocketAddressFromAkkaURL(url); Review comment: I think it would make sense because as is I couldn't tell why something goes into one or the other. But I would do that in a follow-up after this feature is completed to safe some time on rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
