zentol commented on a change in pull request #16265:
URL: https://github.com/apache/flink/pull/16265#discussion_r660564576
##########
File path:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
##########
@@ -85,7 +85,7 @@
public void setupReporter() {
registry =
new MetricRegistryImpl(
-
MetricRegistryConfiguration.defaultMetricRegistryConfiguration(),
+
MetricRegistryTestUtils.defaultMetricRegistryConfiguration(),
Review comment:
The main issue I think is that we don't have a good MetricGroup for
testing, so we have to rely on the runtime implementations which unfortunately
rely on the registry. Overall the metric components are too reliant on each
other.
I should have one such implementation somewhere, which should allow us to
simplify quite a lot of metric-related tests, but I would do that as a
follow-up because it implies bigger changes to all reporter tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
