zhuzhurk commented on a change in pull request #16314:
URL: https://github.com/apache/flink/pull/16314#discussion_r661188503
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionPartitionLifecycleTest.java
##########
@@ -316,7 +317,10 @@ private JobVertex createNoOpJobVertex() {
return jobVertex;
}
- private static class TestingShuffleMaster implements
ShuffleMaster<ShuffleDescriptor> {
+ private static class TestingShuffleMaster
Review comment:
I do not quite understand why we need make `ProducerDescriptor` and
`TestingShuffleMaster` serializable.
Besides that, I tried run `ExecutionPartitionLifecycleTest` locally with
debug log on and do did no see any `NotSerializableException`.
##########
File path:
flink-core/src/main/java/org/apache/flink/util/SerializedValueBase.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package org.apache.flink.util;
+
+import java.io.IOException;
+
+/** Base class of all serialized value. */
+public interface SerializedValueBase<T> extends java.io.Serializable {
Review comment:
Is it possible to avoid introducing such a `SerializedValueBase`, but
let `CompressedSerializedValue` directly extend `SerializedValue`?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/InMemoryBlobWriter.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package org.apache.flink.runtime.blob;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.java.tuple.Tuple2;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Map;
+
+/** In memory implementation of {@link BlobWriter}. */
+public class InMemoryBlobWriter implements BlobWriter {
Review comment:
If we can avoid `SerializedValueBase`, looks to me what this commit does
is to introduce a `InMemoryBlobWriter` which is for testing only?
If so, this change should be part of the last commit and
`InMemoryBlobWriter` should be in test. We can also name it as
`TestingBlobWriter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
